Not considering replicas for deletions if on certain site#21
Closed
dr-stringfellow wants to merge 4 commits intoSmartDataProjects:productionfrom
dr-stringfellow:production
Closed
Not considering replicas for deletions if on certain site#21dr-stringfellow wants to merge 4 commits intoSmartDataProjects:productionfrom dr-stringfellow:production
dr-stringfellow wants to merge 4 commits intoSmartDataProjects:productionfrom
dr-stringfellow:production
Conversation
dr-stringfellow
changed the title
Collaborator
|
Superseded by #22. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is NOT tested yet. Instead, some thoughts are appreciated. Not sure how much it slows the code down, but unless all the replicas are loaded in memory (this will eventually be the case in the server mode), not sure if there is a better way than asking the database each time.